[QA] Use SharingNG to share/list resources in the Given/Then steps #8717

saw-jan · 2024-03-22T04:18:48Z

We are moving from OCS sharing to SharingNG for resource sharing. So let's slowly start using SharingNG in the Given steps to share resource.

Open Tasks:

share using SharingNg in the Given steps

Available Steps

Resource sharing via permission endpoint

And user "Alice" has sent the following resource share invitation:
    | resource        | <resource-name>    |
    | space           | <space-name>       |
    | sharee          | <sharee-name>      |
    | shareType       | <user|group>       |
    | permissionsRole | <permissions-role> |

Space sharing via drives.root endpoint

And user "Alice" has sent the following space share invitation:
    | space           | <space-name>       |
    | sharee          | <sharee-name>      |
    | shareType       | <user|group>       |
    | permissionsRole | <permissions-role> |

Resource link creation via permission endpoint

And user "Alice" has created the following resource link share:
    | resource           | <resource-name>    |
    | space              | <space-name>       |
    | permissionsRole    | <permissions-role> |
    | password           | <password>         |
    | expirationDateTime | <datetime>         |
    | displayName        | <link-name>        |

Space link creation via drives.root endpoint

And user "Alice" has created the following space link share:
    | space              | <space-name>       |
    | permissionsRole    | <permissions-role> |
    | password           | <password>         |
    | expirationDateTime | <datetime>         |
    | displayName        | <link-name>        |

check Then steps (need to be careful)
Cleanup leftovers and step implementation @grgprarup (NOTE)

NOTE: ocs sharing in When steps should not be changed (Keep ocs sharing suites)

Check over these files

Local API Test Suites

API Test Suites

The text was updated successfully, but these errors were encountered:

S-Panta · 2024-04-23T04:18:55Z

What about sharing spaces? @saw-jan

saw-jan · 2024-04-23T05:36:41Z

What about sharing spaces? @saw-jan

All sharing Given steps need to be done using graphAPI wherever possible

S-Panta · 2024-04-29T09:08:36Z

@saw-jan should this acceptance/features/apiReshare/resharing.feature file be refactored?

saw-jan · 2024-04-29T09:23:11Z

@saw-jan should this acceptance/features/apiReshare/resharing.feature file be refactored?

Let's skip that one for now

S-Panta · 2024-05-02T06:57:06Z

I think anyone working in this issue, it would be easier to work as folderwise.

saw-jan · 2024-05-22T07:20:00Z

Cleanup leftovers and step implementation @grgprarup

let's wait for removal of ocs sharing for this.

we can close this if all suites and features have been through

grgprarup · 2024-05-22T08:41:53Z

The graph API steps are used instead of the sharing API in the given steps. All the suites are covered and related PRs are merged so closing this issue.

ScharfViktor · 2024-05-22T09:51:10Z

great job 👍
maybe we could change Given steps for e2e tests?
example https://github.com/owncloud/web/blob/master/tests/e2e/support/api/share/share.ts#L35-L67
@saw-jan do we have task for that?

saw-jan · 2024-05-22T09:59:56Z

do we have task for that?

I don't remember any ticket. If we want to go full-on with sharingNG in e2e then I can create one.

saw-jan · 2024-05-22T10:05:45Z

Anyway, I created the one. owncloud/web#10949

saw-jan added the QA:team label Mar 22, 2024

saw-jan mentioned this issue Mar 25, 2024

[tests-only][full-ci]added test with step definition for mounting share when auto accept env set to false #8623

Merged

9 tasks

nabim777 mentioned this issue Apr 18, 2024

[Sharing NG] Add tests coverage for download shared resources #8662

Closed

9 tasks

nirajacharya2 assigned nirajacharya2 and S-Panta and unassigned nirajacharya2 Apr 18, 2024

S-Panta mentioned this issue Apr 22, 2024

[tests-only][full-ci] changed given statement of sharing link in api antivirus feature file #8914

Merged

9 tasks

Salipa-Gurung self-assigned this Apr 24, 2024

This was referenced Apr 25, 2024

[tests-only] [full-ci] Change given step using SharingNG for share in apiArchiver/downloadById.feature file #8965

Merged

[tests-only] [full-ci] Change given step using SharingNG for share in apiArchiver/downloadByPath.feature file #8990

Merged

PrajwolAmatya assigned grgprarup Apr 29, 2024

grgprarup mentioned this issue Apr 30, 2024

[full-ci] [tests-only] Use sharingNG for sharing in given step #9016

Merged

9 tasks

Salipa-Gurung mentioned this issue May 2, 2024

[tests-only] [full-ci] Change given step for sharing space in apiDownloads #9027

Merged

9 tasks

grgprarup mentioned this issue May 2, 2024

[full-ci] [tests-only] Use sharingNG for sharing in given step, refactored accordingly #9040

Merged

9 tasks

Salipa-Gurung mentioned this issue May 2, 2024

[tests-only] [full-ci] Use sharingNG in given step for sharing in sharesReport.feature file #9045

Merged

9 tasks

S-Panta mentioned this issue May 3, 2024

[tests-only][full-ci]updating given step for sharing in lockfiles #9055

Merged

This was referenced May 3, 2024

[full-ci] [tests-only] Use sharing ng in given steps api search1 suite #9057

Merged

[full-ci] [tests-only] Use sharing ng in given steps api search2 suite #9060

Merged

[full-ci] [tests-only] Use sharing ng in given steps api search content suite #9061

Merged

S-Panta mentioned this issue May 3, 2024

[tests-only] [full-ci] updating given step for sharing in unlockFiles #9063

Merged

grgprarup mentioned this issue May 6, 2024

[full-ci] [tests-only] Used sharing-ng in given steps #9080

Merged

9 tasks

This was referenced May 8, 2024

[tests-only][full-ci] changing given step of creating share in feature file #9105

Merged

[tests-only][full-ci]changing given from ocs to graph in favoritesSharingToShares feature #9118

Merged

grgprarup mentioned this issue May 9, 2024

[full-ci] [tests-only] Used sharing-ng in given steps #9120

Merged

9 tasks

Salipa-Gurung mentioned this issue May 9, 2024

[tests-only] [full-ci] Use sharingNG in remaining feature file of apiSpaces folder #9122

Merged

9 tasks

This was referenced May 13, 2024

[full-ci] [tests-only] Use sharing ng in given steps api spaces shares suite #9140

Merged

[full-ci] [tests-only] Use sharing ng in given steps api spaces shares suite #9143

Merged

S-Panta mentioned this issue May 14, 2024

[tests-only][full-ci]changing given from ocs to graph in feature file #9142

Merged

9 tasks

Salipa-Gurung mentioned this issue May 14, 2024

[tests-only] [full-ci] Use sharingNg in coreApiShareOperationsToShares1 #9162

Merged

9 tasks

grgprarup mentioned this issue May 15, 2024

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9174

Merged

9 tasks

S-Panta mentioned this issue May 16, 2024

[tests-only][full-ci]changing given from ocs to graph in feature file #9184

Merged

9 tasks

Salipa-Gurung mentioned this issue May 16, 2024

[tests-only] [full-ci] Use sharingNG in coreApiShareOperationsToShares2 #9191

Merged

9 tasks

Salipa-Gurung mentioned this issue May 20, 2024

[tests-only] [full-ci] Update given step using sharingNg in coreApiShareUpdateToShares #9218

Merged

9 tasks

grgprarup unassigned Salipa-Gurung and S-Panta May 21, 2024

grgprarup mentioned this issue May 21, 2024

[full-ci] [tests-only] Use sharing-ng in given steps for sharing #9221

Merged

9 tasks

grgprarup closed this as completed May 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QA] Use SharingNG to share/list resources in the Given/Then steps #8717

[QA] Use SharingNG to share/list resources in the Given/Then steps #8717

saw-jan commented Mar 22, 2024 •

edited

S-Panta commented Apr 23, 2024

saw-jan commented Apr 23, 2024

S-Panta commented Apr 29, 2024

saw-jan commented Apr 29, 2024

S-Panta commented May 2, 2024 •

edited

saw-jan commented May 22, 2024

grgprarup commented May 22, 2024

ScharfViktor commented May 22, 2024

saw-jan commented May 22, 2024

saw-jan commented May 22, 2024 •

edited

[QA] Use SharingNG to share/list resources in the Given/Then steps #8717

[QA] Use SharingNG to share/list resources in the Given/Then steps #8717

Comments

saw-jan commented Mar 22, 2024 • edited

S-Panta commented Apr 23, 2024

saw-jan commented Apr 23, 2024

S-Panta commented Apr 29, 2024

saw-jan commented Apr 29, 2024

S-Panta commented May 2, 2024 • edited

saw-jan commented May 22, 2024

grgprarup commented May 22, 2024

ScharfViktor commented May 22, 2024

saw-jan commented May 22, 2024

saw-jan commented May 22, 2024 • edited

saw-jan commented Mar 22, 2024 •

edited

S-Panta commented May 2, 2024 •

edited

saw-jan commented May 22, 2024 •

edited