Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing gatewaysvc config #1716

Merged
merged 1 commit into from Feb 25, 2021
Merged

add missing gatewaysvc config #1716

merged 1 commit into from Feb 25, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 25, 2021

The auth provider ldap and oidc drivers now need to be able talk to the reva gateway. We added the gatewayscv to the config that is passed to reva.

@butonic
add missing gatewaysvc config
059bec1 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the add-missing-gatewaysvc-config branch from a9e5c66 to 059bec1 Compare February 25, 2021 08:41
wkloucek
wkloucek approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 00659b6 into master Feb 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-missing-gatewaysvc-config branch February 25, 2021 19:50
ownclouders pushed a commit that referenced this pull request Feb 25, 2021
@butonic
commit 00659b6
24efb11 
Merge: a7b2f4d 059bec1
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Thu Feb 25 20:50:50 2021 +0100

    Merge pull request #1716 from owncloud/add-missing-gatewaysvc-config

    add missing gatewaysvc config
@micbar micbar mentioned this pull request Mar 9, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@butonic @wkloucek