Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop supervisor if a service fails to start #1963

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Stop supervisor if a service fails to start #1963

merged 3 commits into from
Apr 26, 2021

Conversation

refs
Copy link
Member

@refs refs commented Apr 23, 2021

closes #1616

Steps to make the supervisor fail:

PROXY_HTTP_ADDR=0.0.0.0:9144 bin/ocis server

@update-docs
Copy link

update-docs bot commented Apr 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

wkloucek
wkloucek approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! No silent fail anymore if a port is already in use 👍

@wkloucek wkloucek merged commit ad1349a into master Apr 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-1616 branch April 26, 2021 06:33
ownclouders pushed a commit that referenced this pull request Apr 26, 2021
@wkloucek
commit ad1349a
3fa5bca 
Merge: 8913e37 4204470
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Apr 26 08:33:26 2021 +0200

    Merge pull request #1963 from owncloud/fix-1616

    Stop supervisor if a service fails to start
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort ocis server process when one component cannot be initialized
2 participants
@refs @wkloucek