forward basic auth to OpenID connect token authentication endpoint #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
C0rby
reviewed
May 31, 2021
| // The token auth endpoint uses basic auth for clients, see https://openid.net/specs/openid-connect-basic-1_0.html#TokenRequest | ||
| // > The Client MUST authenticate to the Token Endpoint using the HTTP Basic method, as described in 2.3.1 of OAuth 2.0. | ||
| func (m basicAuth) isOIDCTokenAuth(req *http.Request) bool { | ||
| return req.URL.Path == "/konnect/v1/token" |
There was a problem hiding this comment.
This is now hard-coded for konnectd. What about other IDPs?
There was a problem hiding this comment.
Other IdPs won't be hidden behind our proxy.
There was a problem hiding this comment.
I see. Then it should be ok, I guess.
C0rby
approved these changes
May 31, 2021
| // The token auth endpoint uses basic auth for clients, see https://openid.net/specs/openid-connect-basic-1_0.html#TokenRequest | ||
| // > The Client MUST authenticate to the Token Endpoint using the HTTP Basic method, as described in 2.3.1 of OAuth 2.0. | ||
| func (m basicAuth) isOIDCTokenAuth(req *http.Request) bool { | ||
| return req.URL.Path == "/konnect/v1/token" |
There was a problem hiding this comment.
I see. Then it should be ok, I guess.
|
needs rebase |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
oidc-token-basic-auth
branch
from
c962d58
to
c3951d6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2094