Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph refactorings #2277

Merged
merged 3 commits into from
Jul 21, 2021
Merged

graph refactorings #2277

merged 3 commits into from
Jul 21, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 9, 2021

update the code to match the reva dav/spaces pr cs3org/reva#1803

  • use a middleware to always authenticate requests using the access token minted by the ocis proxy
  • remove ldap
  • remove oidc
  • use cs3 api to look up users, groups, drives and driveitems
  • always use json errors

@update-docs
Copy link

update-docs bot commented Jul 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the title graph refatcorings graph refactorings Jul 9, 2021
@butonic butonic requested review from refs and C0rby July 10, 2021 20:30
@butonic
graph: refactor auth and middlewares
5070941 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
get rid of ldap and oidc, refactor error handling
2a54b64 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review July 21, 2021 09:02
@butonic
add changelog
900f8db 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
9.2% 9.2% Duplication

@butonic butonic merged commit f322516 into master Jul 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the spaces-api branch July 21, 2021 10:59
ownclouders pushed a commit that referenced this pull request Jul 21, 2021
@butonic
commit f322516
bae1ac6 
Merge: 1af7518 900f8db
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Wed Jul 21 12:59:11 2021 +0200

    Merge pull request #2277 from owncloud/spaces-api

    graph refactorings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@butonic @C0rby