Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocs cache warmup config and warn on protobuf ns conflicts #2328

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Jul 26, 2021

This PR introduces a couple of changes:

  • Since v1.26.0, protobuf panics in case of namespace conflicts instead of warning. This does not allow us to integrate extensions in oCIS for which the proto bindings were generated separately, despite the fact that go_package was different for the extensions' protobufs. For the time being, we set this back to warn (like it was in the previous versions) until we can find a solution.
  • We added a cache warmup strategy for the resources in the ocs layer. We stat every resource when a user lists their shares, which introduced a bit of latency. To handle that, we introduced a cache for these resources. This PR goes a bit further and adds a strategy through which we can populate the cache even before the first user request, further enhancing the user experience. Currently, we have only a single strategy for the CERNBox-specific drivers, I'll add a generic one as well.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.9% 21.9% Coverage
22.8% 22.8% Duplication

@micbar
Copy link
Contributor

micbar commented Jul 28, 2021

@ishank011 I see no reason against this, but it would help to have a PR description for the use case 😄

@ishank011
Copy link
Contributor Author

@micbar added the details

@labkode
Copy link
Contributor

labkode commented Aug 2, 2021

@micbar can we get it in?

@micbar micbar merged commit fba3688 into owncloud:master Aug 2, 2021
ownclouders pushed a commit that referenced this pull request Aug 2, 2021
Merge: ad0e7fe f7867e4
Author: Michael Barz <mbarz@owncloud.com>
Date:   Mon Aug 2 08:58:33 2021 +0200

    Merge pull request #2328 from ishank011/ocs-cache-warmup

    Add ocs cache warmup config and warn on protobuf ns conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants