Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update reva to v1.11.0 #2355

Merged
merged 6 commits into from
Aug 5, 2021
Merged

[full-ci] update reva to v1.11.0 #2355

merged 6 commits into from
Aug 5, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Aug 5, 2021

No description provided.

@update-docs
Copy link

update-docs bot commented Aug 5, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis
Copy link
Contributor

I suggested that we merge #2353 - that should finish CI in about 20 minutes. Then rebase this PR, so that we get a full up-to-date set of CI.

@fschade
Copy link
Contributor Author

fschade commented Aug 5, 2021

I suggested that we merge #2353 - that should finish CI in about 20 minutes. Then rebase this PR, so that we get a full up-to-date set of CI.

good point, CI canceled

wkloucek
wkloucek approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for caring :-)

@phil-davis
Copy link
Contributor

@fschade PR #2353 has been merged. Please rebase this and we can get it merged!

@fschade
Copy link
Contributor Author

fschade commented Aug 5, 2021

@fschade PR #2353 has been merged. Please rebase this and we can get it merged!

done

@phil-davis
Copy link
Contributor

I removed the passing tests from expected-failures. That gets CI running again, and it should pass.

runsh: Total unexpected passed scenarios throughout the test run:
apiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature:22
apiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature:23

runsh: Total unexpected passed scenarios throughout the test run:
apiTrashbinRestore/trashbinRestore.feature:309
apiTrashbinRestore/trashbinRestore.feature:310
apiTrashbinRestore/trashbinRestore.feature:478
apiTrashbinRestore/trashbinRestore.feature:479

https://drone.owncloud.com/owncloud/ocis/6231/28/6
https://drone.owncloud.com/owncloud/ocis/6231/36/6

There were no newly-passing tests on owncloud storage - so some stuff was fixed for ocis storage but not for owncloud storage. Anyway, testing "owncloud" storage is being removed in PR #2351 (which we can sort out after this PR is merged)

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

Anyone please feel free to merge this if CI goes green.

@fschade
Copy link
Contributor Author

fschade commented Aug 5, 2021 •
edited

Anyone please feel free to merge this if CI goes green.

Sitting in front of it and have my fingers crossed. I merge it once green

@fschade fschade merged commit 396c24a into master Aug 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva-v1.11.0 branch August 5, 2021 19:15
ownclouders pushed a commit that referenced this pull request Aug 5, 2021
@fschade
commit 396c24a
c3fb0db 
Merge: 8bd46f2 8a645f6
Author: Florian Schade <f.schade@icloud.com>
Date:   Thu Aug 5 21:15:23 2021 +0200

    Merge pull request #2355 from owncloud/update-reva-v1.11.0

    [full-ci] update reva to v1.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek wkloucek approved these changes

@refs refs Awaiting requested review from refs

@individual-it individual-it Awaiting requested review from individual-it

@kulmann kulmann Awaiting requested review from kulmann

@micbar micbar Awaiting requested review from micbar

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fschade @phil-davis @butonic @wkloucek