Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove invalid json:"omit" added in owncloud/ocis#2437 #2625

Merged
merged 1 commit into from Oct 15, 2021
Merged

remove invalid json:"omit" added in owncloud/ocis#2437 #2625

merged 1 commit into from Oct 15, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 14, 2021 •
edited

Description

Remove the invalid json:"omit" added in #2437.

It doesn't change any functionality / doesn't fix any bug. It only fixes the code, therefore no changelog.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 14, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from refs and removed request for kulmann and pascalwengerter October 14, 2021 15:08
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@refs refs merged commit 2303ca3 into master Oct 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_json_omit branch October 15, 2021 05:58
ownclouders pushed a commit that referenced this pull request Oct 15, 2021
@refs
commit 2303ca3
f075b9e 
Merge: 43b624a 9f28316
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Fri Oct 15 07:58:41 2021 +0200

    Merge pull request #2625 from owncloud/fix_json_omit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @refs