Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix basic auth configuration #2719

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix basic auth configuration #2719

merged 1 commit into from
Nov 2, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Nov 2, 2021

Description

Make basic auth only work when explicitly configured.

Related Issue

Motivation and Context

Basic auth was still working even though PROXY_ENABLE_BASIC_AUTH was set to false.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Code changes

@C0rby C0rby added the Status:Needs-Review Needs review from a maintainer label Nov 2, 2021
@C0rby C0rby requested review from refs and wkloucek November 2, 2021 14:06
@C0rby C0rby self-assigned this Nov 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@C0rby C0rby merged commit 04ce16e into master Nov 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-basic-auth branch November 2, 2021 15:02
ownclouders pushed a commit that referenced this pull request Nov 2, 2021
commit 04ce16e
8784250 
Merge: 424a2e3 890fbd5
Author: David Christofas <dchristofas@owncloud.com>
Date:   Tue Nov 2 16:02:26 2021 +0100

    Merge pull request #2719 from owncloud/fix-basic-auth

    fix basic auth configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@refs refs Awaiting requested review from refs

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@C0rby C0rby

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy accepts basic auth requests even when PROXY_ENABLE_BASIC_AUTH is false
2 participants
@C0rby @rhafer