Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update reva to get cs3org/reva#2230 #2726

Merged
merged 1 commit into from
Nov 11, 2021
Merged

[full-ci] update reva to get cs3org/reva#2230 #2726

merged 1 commit into from
Nov 11, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 4, 2021 •
edited

Description

Update REVA to get cs3org/reva#2230 for owncloud/web#5970 (comment)

Related Issue

Motivation and Context

Make the default app accessible to oC Web

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek marked this pull request as draft November 4, 2021 13:40
@wkloucek wkloucek marked this pull request as ready for review November 10, 2021 11:39
@wkloucek wkloucek mentioned this pull request Nov 10, 2021
Merged
11 tasks
@wkloucek wkloucek self-assigned this Nov 10, 2021
@C0rby C0rby mentioned this pull request Nov 10, 2021
Merged
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kulmann
kulmann approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 24b51da into master Nov 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the reva_default_app branch November 11, 2021 15:07
ownclouders pushed a commit that referenced this pull request Nov 11, 2021
@kulmann
commit 24b51da
6e09bd7 
Merge: 45c3b07 719df3c
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Thu Nov 11 16:07:17 2021 +0100

    Merge pull request #2726 from owncloud/reva_default_app

    [full-ci] update reva to get cs3org/reva#2230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@wkloucek wkloucek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @kulmann