Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opening images in media viewer for some usernames #2738

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix opening images in media viewer for some usernames #2738

merged 1 commit into from
Nov 9, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 9, 2021 •
edited

Description

Users with a username like foo@baz.test can not view images in the media viewer. This PR fixes that.

Related Issue

Motivation and Context

some oCIS installations might use email addresses as username.

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested a review from C0rby November 9, 2021 10:01
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek requested a review from kobergj November 9, 2021 12:04
@wkloucek wkloucek merged commit 17a5991 into master Nov 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_mediaviewer_url_encoded branch November 9, 2021 14:06
ownclouders pushed a commit that referenced this pull request Nov 9, 2021
@wkloucek
commit 17a5991
08c87bc 
Merge: 3f8bebc cdb9038
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Nov 9 15:06:25 2021 +0100

    Merge pull request #2738 from owncloud/fix_mediaviewer_url_encoded

    fix opening images in media viewer for some usernames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @kobergj