[full-ci] Bump web to v4.5.0 #2780
Conversation
pascalwengerter
requested review from
individual-it,
micbar,
phil-davis and
wkloucek
as code owners
pascalwengerter
force-pushed
the
update-web-4.5.0
branch
2 times, most recently
from
2c48435
to
be13acf
Compare
pascalwengerter
force-pushed
the
update-web-4.5.0
branch
from
be13acf
to
c7cdccf
Compare
pascalwengerter
force-pushed
the
update-web-4.5.0
branch
from
f97b57e
to
f549d71
Compare
| cp -r "$WEB_PATH"/tests/acceptance/stepDefinitions "$testFolder" | ||
| cp "$WEB_PATH"/tests/acceptance/setup.js "$testFolder" | ||
| cp -r "$WEB_PATH"/tests/acceptance/* "$testFolder" | ||
| rm -r $testFolder/node_modules |
There was a problem hiding this comment.
Could we do cp -r !(node_modules) "$WEB_PATH"/tests/acceptance/* or the likes instead of copying and removing those gazillion files? :)
There was a problem hiding this comment.
yes, and also I think we don't need one yarn install in drone
.drone.star
Outdated
| @@ -751,6 +755,9 @@ def settingsUITests(ctx, storage = "ocis", accounts_hash_difficulty = 4): | |||
| "cd /srv/app/web", | |||
| "git checkout $WEB_COMMITID", | |||
| "yarn install --immutable", | |||
| "yarn build", | |||
There was a problem hiding this comment.
@individual-it not sure if we need to build web here btw, just added it since it seemed like it was missing yet tests passed before without problems apparently
| @@ -46,7 +46,7 @@ clean_up() { | |||
|
|
|||
| trap clean_up SIGHUP SIGINT SIGTERM EXIT | |||
|
|
|||
| cp -r "$WEB_PATH"/tests "$testFolder" | |||
| cp -r $(ls -d "$WEB_PATH"/tests/acceptance/* | grep -v 'node_modules') "$testFolder" | |||
There was a problem hiding this comment.
Guess we should also omit all the files in .yarn from being copied here
| @@ -40,7 +40,7 @@ clean_up() { | |||
|
|
|||
| trap clean_up SIGHUP SIGINT SIGTERM EXIT | |||
|
|
|||
| cp -r "$WEB_PATH"/tests "$testFolder" | |||
| cp -r $(ls -d "$WEB_PATH"/tests/acceptance/* | grep -v 'node_modules') "$testFolder" | |||
There was a problem hiding this comment.
Guess we should also omit all the files in .yarn from being copied here
There was a problem hiding this comment.
.yarn will not be copied with that command because it will only copy the output of ls -d (no -a in the ls command)
| @@ -47,6 +47,7 @@ | |||
| "@rollup/plugin-json": "^4.0.1", | |||
| "@rollup/plugin-replace": "^2.3.0", | |||
| "archiver": "^5.3.0", | |||
| "chromedriver": "^93.0.1", | |||
There was a problem hiding this comment.
Isn't that one coming from the tests/acceptance/package.json ? (the same would apply for settings/package.json)
wkloucek
force-pushed
the
update-web-4.5.0
branch
from
32ce7d0
to
d2395f5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Description
Works towards #2766