Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement graph endpoint to delete spaces #2979

Merged
merged 1 commit into from Jan 20, 2022
Merged

implement graph endpoint to delete spaces #2979

merged 1 commit into from Jan 20, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 18, 2022

Description

Added a new graph endpoint to delete and purge spaces.

Motivation and Context

We needed a way to delete spaces.

How Has This Been Tested?

  • locally using curl and the graph-explorer

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added (some)
  • Acceptance tests added
  • Documentation ticket raised:

@C0rby C0rby requested review from butonic and micbar January 18, 2022 16:19
@C0rby C0rby self-assigned this Jan 18, 2022
kobergj
kobergj requested changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvable if I wasn't so picky...

graph/pkg/service/v0/service.go Outdated Show resolved Hide resolved
proxy/pkg/middleware/create_home.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.8% 12.8% Coverage
15.4% 15.4% Duplication

@C0rby C0rby requested a review from kobergj January 20, 2022 11:03
kobergj
kobergj approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@C0rby C0rby merged commit d15dcdb into master Jan 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the delete-spaces branch January 20, 2022 11:22
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

@micbar micbar Awaiting requested review from micbar

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@C0rby @kobergj