Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more proxy routes for thumbnails #3567

Merged
merged 8 commits into from
May 5, 2022
Merged

add more proxy routes for thumbnails #3567

merged 8 commits into from
May 5, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 22, 2022 •
edited

Description

adds more routes to the proxy for thumbnail previews.

also adds omitempty to the routes config struct, to slim down the configuration example in https://owncloud.dev/extensions/proxy/configuration/

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from butonic and C0rby April 22, 2022 09:16
@ownclouders
Copy link
Contributor

ownclouders commented Apr 22, 2022 •
edited

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@felix-schwarz felix-schwarz mentioned this pull request Apr 22, 2022
Closed
@wkloucek wkloucek marked this pull request as draft April 22, 2022 14:32
@wkloucek wkloucek marked this pull request as ready for review April 26, 2022 12:22
@wkloucek wkloucek requested a review from C0rby April 26, 2022 12:22
@butonic
use WhoAmI to look up user for legacy webdav endpoints
fd99547 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

2.0% 2.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 87147ed into owncloud:master May 5, 2022
ownclouders pushed a commit that referenced this pull request May 5, 2022
@butonic
commit 87147ed
5f4907b 
Merge: 761d72d fd99547
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Thu May 5 19:07:47 2022 +0000

    Merge pull request #3567 from wkloucek/proxy-thumbnails

    add more proxy routes for thumbnails
@wkloucek wkloucek deleted the proxy-thumbnails branch May 5, 2022 19:31
@micbar micbar mentioned this pull request May 10, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview API endpoint returns Markdown for Markdown files
4 participants
@wkloucek @ownclouders @butonic @C0rby