Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align service naming #3606

Merged
merged 5 commits into from
May 2, 2022
Merged

Align service naming #3606

merged 5 commits into from
May 2, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented Apr 27, 2022 •
edited

We now reflect the configured service names when listing them in the ocis runtime.

Follow up PRs:

  • rename storage-metadata -> just metadata
  • rename ocis commands to reflect changed names, eg storageapprovider.go -> approvider.go with the command name storage-app-provider -> app-provider
  • always use the correct service names in the .drone.star file OCIS_RUN_EXTENSIONS

partly fixes #3603

@butonic butonic requested a review from C0rby April 27, 2022 15:15
@butonic butonic force-pushed the align-service-naming branch 3 times, most recently from 39356fa to 42a1e4c Compare April 27, 2022 15:47
@butonic
use configured names as service names in ocis runtime
09b9c5a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add changelog
88b892a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ownclouders
Copy link
Contributor

ownclouders commented Apr 28, 2022 •
edited

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@butonic
correct service names for group and storage-shares
c86d9fb 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
use correct service names in .drone.star
4b3c3c7 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
phil-davis
phil-davis approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

wkloucek
wkloucek requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should then also rename the respective config in ocis-pkg/config/config.go

@butonic
align ocis-pkg/config/config.go
c3826ac 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Apr 29, 2022

@wkloucek like so: c3826ac

and what about graph_explorer in extensions/graph-explorer/pkg/config/config.go

@butonic butonic requested a review from wkloucek April 29, 2022 06:38
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.5% 2.5% Duplication

C0rby
C0rby approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@micbar micbar mentioned this pull request Apr 29, 2022
Closed
45 tasks
@kobergj kobergj merged commit 0642a5e into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the align-service-naming branch May 2, 2022 10:44
ownclouders pushed a commit that referenced this pull request May 2, 2022
@butonic
commit 0642a5e
1fae68c 
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Mon May 2 12:44:21 2022 +0200

    Align service naming (#3606)

    * use configured names as service names in ocis runtime

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * add changelog

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * correct service names for group and storage-shares

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * use correct service names in .drone.star

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * align ocis-pkg/config/config.go

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@C0rby C0rby C0rby approved these changes

@kobergj kobergj kobergj approved these changes

@wkloucek wkloucek wkloucek approved these changes

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

align service names in runtime with dir layout
6 participants
@butonic @ownclouders @phil-davis @C0rby @kobergj @wkloucek