Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce drives in listing of graph /me/drives API #3629

Closed
wants to merge 2 commits into from
Closed

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Apr 29, 2022

Description

Reduced the drives in the graph /me/drives API to only the drives the user has access to.
The endpoint /drives will list all drives when the user has the permission.

Motivation and Context

The clients want a list of drives the current user can access. The listing for managing spaces can still be done via the /drives endpoint.

How Has This Been Tested?

  • test environment: locally with the graph-explorer

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes

@C0rby C0rby self-assigned this Apr 29, 2022
@C0rby C0rby mentioned this pull request Apr 29, 2022
45 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Apr 29, 2022

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

URL decode href before comparing with a given string
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@micbar
Copy link
Contributor

micbar commented May 2, 2022

was merged as part of #3637

@micbar micbar closed this May 2, 2022
@butonic butonic deleted the graph-me-drives branch November 7, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants