Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable user-management webui #3633

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Enable user-management webui #3633

merged 1 commit into from
Apr 29, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Apr 29, 2022

The switch to libregraph/idm happend we can enable the new UI.

@rhafer rhafer self-assigned this Apr 29, 2022
@update-docs
Copy link

update-docs bot commented Apr 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann requested changes Apr 29, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensions/web/pkg/service/v0/service.go still contains the accounts ui js bundle in the external apps config. Could you remove that in this PR?

@rhafer
Enable user-management webui
9bf1dcb 
The switch to libregraph/idm happend we can enable the new UI.
@rhafer rhafer requested a review from kulmann April 29, 2022 12:47
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@butonic butonic merged commit 9f4bb8f into owncloud:master Apr 29, 2022
ownclouders pushed a commit that referenced this pull request Apr 29, 2022
@butonic
commit 9f4bb8f
b46b6bb 
Merge: 22fb706 9bf1dcb
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Fri Apr 29 15:38:21 2022 +0200

    Merge pull request #3633 from rhafer/enable-usermanagent

    Enable user-management webui
@micbar micbar mentioned this pull request May 10, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhafer @butonic @kulmann