[full-ci] use new space ID util functions #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled... |
C0rby
changed the title
C0rby
force-pushed
the
new-space-id-functions
branch
from
2551be9
to
43527b6
Compare
C0rby
force-pushed
the
new-space-id-functions
branch
from
43527b6
to
7fc9321
Compare
C0rby
force-pushed
the
new-space-id-functions
branch
from
7fc9321
to
3d02a15
Compare
kobergj
approved these changes
May 3, 2022
C0rby
force-pushed
the
new-space-id-functions
branch
from
3d02a15
to
958b4fe
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed code to use the new space ID util functions so that everything works with the new spaces ID format.
Motivation and Context
We had multiple functions to parse or format the storage space id.
When we recently changed the format of the storage space id some places broke. Instead of just fixing the broken things locally I replaced it with the correct implementation from the Reva package. This package is used everywhere and will hopefully be kept compatible to the changing formats.
This will also fix thumbnails in spaces.
Needs this Reva PR first: cs3org/reva#2816.
How Has This Been Tested?
Types of changes
Checklist: