Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MachineAuthAPIKey -> SystemUserAPIKey #3672

Merged
merged 7 commits into from
May 4, 2022
Merged

MachineAuthAPIKey -> SystemUserAPIKey #3672

merged 7 commits into from
May 4, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented May 4, 2022

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kobergj
split machineauthapikey and systemuserapikey
8846a1b 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
changelog
7d5a4f4 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj mentioned this pull request May 4, 2022
Closed
45 tasks
@ownclouders
Copy link
Contributor

ownclouders commented May 4, 2022 •
edited

💥 Acceptance test localApiTests-apiArchiver-ocis failed. Further test are cancelled...

butonic
butonic requested changes May 4, 2022
View reviewed changes
extensions/settings/pkg/config/parser/parse.go Outdated Show resolved Hide resolved
extensions/sharing/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
extensions/sharing/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
extensions/storage-system/pkg/config/config.go Outdated Show resolved Hide resolved
extensions/storage-system/pkg/config/parser/parse.go Outdated Show resolved Hide resolved
ocis/pkg/init/init.go Outdated Show resolved Hide resolved
@kobergj kobergj requested a review from butonic May 4, 2022 11:31
@butonic
use correct machine auth api key
6d9ce10 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj mentioned this pull request May 4, 2022
Closed
@kobergj kobergj merged commit eb59d22 into owncloud:master May 4, 2022
@kobergj kobergj deleted the MachineAuthAPIKey-to-SystemUserAPIKey branch May 4, 2022 13:48
ownclouders pushed a commit that referenced this pull request May 4, 2022
@kobergj
commit eb59d22
8f968cb 
Author: kobergj <jkoberg@owncloud.com>
Date:   Wed May 4 15:48:02 2022 +0200

    MachineAuthAPIKey -> SystemUserAPIKey (#3672)

    * split machineauthapikey and systemuserapikey

    Signed-off-by: jkoberg <jkoberg@owncloud.com>

    * changelog

    Signed-off-by: jkoberg <jkoberg@owncloud.com>

    * specific errors and some reverts

    Signed-off-by: jkoberg <jkoberg@owncloud.com>

    * use correct machine auth api key

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kobergj @ownclouders @butonic