Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit when encountering config parsing errors #3743

Merged
merged 1 commit into from
May 9, 2022
Merged

Exit when encountering config parsing errors #3743

merged 1 commit into from
May 9, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented May 9, 2022 •
edited

Description

When one of the required secrets is not set or the config parsing has returned an error, stop the runtime by calling os.Exit(1)

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested review from wkloucek, butonic, kulmann, pascalwengerter and kobergj and removed request for kulmann and pascalwengerter May 9, 2022 09:50
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
86.8% 86.8% Duplication

@micbar micbar merged commit 8145478 into master May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the exit-on-parse-error branch May 9, 2022 11:33
ownclouders pushed a commit that referenced this pull request May 9, 2022
@micbar
commit 8145478
1c74456 
Merge: 19d7acb f6e2f46
Author: Michael Barz <mbarz@owncloud.com>
Date:   Mon May 9 13:33:28 2022 +0200

    Merge pull request #3743 from owncloud/exit-on-parse-error

    Exit when encountering config parsing errors
@micbar micbar mentioned this pull request May 10, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@butonic butonic Awaiting requested review from butonic

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micbar @wkloucek