Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose IDP secret configuration via environment variables #3744

Merged
merged 1 commit into from
May 9, 2022
Merged

expose IDP secret configuration via environment variables #3744

merged 1 commit into from
May 9, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 9, 2022

Description

Bugfix: Make IDP secrets configurable via environment variables

We've fixed the configuration options of the IDP to make the IDP secrets again
configurable via environment variables.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from butonic, C0rby and micbar May 9, 2022 10:03
@ownclouders
Copy link
Contributor

ownclouders commented May 9, 2022 •
edited

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit dedd522 into owncloud:master May 9, 2022
@wkloucek wkloucek deleted the idp-env-secrets branch May 9, 2022 11:36
ownclouders pushed a commit that referenced this pull request May 9, 2022
@wkloucek
commit dedd522
5439cfa 
Merge: e028632 f2e44c6
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon May 9 13:36:04 2022 +0200

    Merge pull request #3744 from wkloucek/idp-env-secrets

    expose IDP secret configuration via environment variables
ownclouders pushed a commit that referenced this pull request May 9, 2022
@wkloucek
commit dedd522
3d570c9 
Merge: e028632 f2e44c6
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon May 9 13:36:04 2022 +0200

    Merge pull request #3744 from wkloucek/idp-env-secrets

    expose IDP secret configuration via environment variables
@micbar micbar mentioned this pull request May 10, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @ownclouders @butonic