Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix thumbnails for empty trailing paths #3791

Merged
merged 1 commit into from
May 13, 2022
Merged

fix thumbnails for empty trailing paths #3791

merged 1 commit into from
May 13, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented May 12, 2022

Description

Bugfix: Fix Thumbnails for IDs without a trailing path

The routes in the chi router were not matching thumbnail requests without a trailing path.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested review from C0rby, kobergj and kulmann May 12, 2022 16:35
@micbar micbar requested a review from wkloucek May 12, 2022 16:36
@micbar micbar mentioned this pull request May 12, 2022
Closed
@ownclouders
Copy link
Contributor

ownclouders commented May 12, 2022 •
edited

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 42c4abb into master May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the thumnails-id branch May 13, 2022 07:28
ownclouders pushed a commit that referenced this pull request May 13, 2022
@micbar
commit 42c4abb
a627fb8 
Merge: 9ccde70 eb07e05
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri May 13 09:28:55 2022 +0200

    Merge pull request #3791 from owncloud/thumnails-id

    fix thumbnails for empty trailing paths
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kobergj kobergj kobergj approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single File user shares preview broke and download action missing
4 participants
@micbar @ownclouders @C0rby @kobergj