Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify ocis subcommands #3796

Merged
merged 1 commit into from
May 16, 2022
Merged

unify ocis subcommands #3796

merged 1 commit into from
May 16, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 13, 2022 •
edited

Description

We've fixed the behavior for ocis search, which didn't show further help when not all secrets have been configured.
It also was not possible to start the search service standalone from the oCIS binary without configuring all oCIS secrets,
even they were not needed by the search service.

Additionally:

  • moved the SubcommandDescription function into a helper package, ensure that it is used by all extensions
  • ensure that all services use ther service name for the subcommands name

Related Issue

Motivation and Context

The search service should be startable without configuring all oCIS secrets

How Has This Been Tested?

  • ocis search should always yield a help, also if no secrets are configured

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review May 16, 2022 06:03
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

dragonchaser
dragonchaser approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek merged commit 6394ec2 into owncloud:master May 16, 2022
@wkloucek wkloucek deleted the unify-ocis-commands branch May 16, 2022 07:46
ownclouders pushed a commit that referenced this pull request May 16, 2022
@wkloucek
commit 6394ec2
3e93a00 
Merge: ae4ec53 44c909b
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon May 16 09:46:32 2022 +0200

    Merge pull request #3796 from wkloucek/unify-ocis-commands

    unify ocis subcommands
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @dragonchaser