Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused transfer secret from app provider #3798

Merged
merged 1 commit into from
May 16, 2022
Merged

remove unused transfer secret from app provider #3798

merged 1 commit into from
May 16, 2022

Conversation

wkloucek
Copy link
Contributor

Description

We've fixed the startup of the app provider by removing the startup dependency
on a configured transfer secret, which was not used. This only happend if you
start the app provider without runtime (eg. ocis app-provider server) and didn't
have configured all oCIS secrets.

Related Issue

Motivation and Context

only have dependencies on secrets that are needed

How Has This Been Tested?

  • none

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek mentioned this pull request May 16, 2022
Closed
9 tasks
dragonchaser
dragonchaser approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek mentioned this pull request May 16, 2022
Merged
9 tasks
@wkloucek wkloucek merged commit 7a7a343 into owncloud:master May 16, 2022
ownclouders pushed a commit that referenced this pull request May 16, 2022
@wkloucek
commit 7a7a343
f79efd4 
Merge: 6394ec2 4b73b32
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon May 16 09:46:51 2022 +0200

    Merge pull request #3798 from wkloucek/app-provider-unused-transfer-secret

    remove unused transfer secret from app provider
@wkloucek wkloucek deleted the app-provider-unused-transfer-secret branch May 20, 2022 07:39
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@butonic butonic Awaiting requested review from butonic

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @dragonchaser