Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow overwriting a default value by setting an empty envirionment variable #3892

Merged
merged 1 commit into from
May 31, 2022
Merged

allow overwriting a default value by setting an empty envirionment variable #3892

merged 1 commit into from
May 31, 2022
+14 −5

Conversation

wkloucek
Copy link
Contributor

Description

allow overwriting a default value by setting an empty enviornment variable

Related Issue

  • Fixes <issue_link>

Motivation and Context

assuming, that you don't want to have a ldap ca cert, you may want to set LDAP_CACERT="". This didn't work prior to this change.

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review May 30, 2022 14:15
rhafer
rhafer approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Provided the test succeed.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit bab952a into owncloud:master May 31, 2022
ownclouders pushed a commit that referenced this pull request May 31, 2022
@wkloucek
commit bab952a
d916ea5 
Merge: 499748f 8883042
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue May 31 07:41:04 2022 +0200

    Merge pull request #3892 from wkloucek/env-allow-empty-override

    allow overwriting a default value by setting an empty envirionment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @rhafer