Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration validation for extensions' server commands #3911

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix configuration validation for extensions' server commands #3911

merged 1 commit into from
Jun 2, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jun 2, 2022

Description

Bugfix: Fix configuration validation for extensions' server commands

We've fixed the configuration validation for the extensions' server commands.
Before that fix error messages have occurred when started services which don't need
certain configuration values, that are needed for the oCIS fullstack command.

We now no longer do the common oCIS configuration validation for extensions' server
commands and now rely only on the extensions' validation function.

Related Issue

Motivation and Context

Skip confusing "error" messages

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from rhafer June 2, 2022 07:58
@wkloucek wkloucek changed the title e Fix configuration validation for extensions' server commands Jun 2, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 3c24109 into owncloud:master Jun 2, 2022
@wkloucek wkloucek deleted the skip-ocis-common-validate branch June 2, 2022 12:24
ownclouders pushed a commit that referenced this pull request Jun 2, 2022
@wkloucek
commit 3c24109
1d442c9 
Merge: 2159584 27b2fbe
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Jun 2 14:24:38 2022 +0200

    Merge pull request #3911 from wkloucek/skip-ocis-common-validate

    Fix configuration validation for extensions' server commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @ownclouders @rhafer