Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config option to enable or disable TLS for nats #4867

Merged
merged 3 commits into from
Oct 21, 2022
Merged

add config option to enable or disable TLS for nats #4867

merged 3 commits into from
Oct 21, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Oct 20, 2022

Requires: cs3org/reva#3382
This is necessary to not break existing setups.

Required for: #4818

Per default TLS is not enabled but can be enabled by setting either OCIS_EVENTS_ENABLE_TLS=true or the respective service configs:

  • AUDIT_EVENTS_ENABLE_TLS=true
  • GRAPH_EVENTS_ENABLE_TLS=true
  • NATS_EVENTS_ENABLE_TLS=true
  • NOTIFICATIONS_EVENTS_ENABLE_TLS=true
  • SEARCH_EVENTS_ENABLE_TLS=true
  • SHARING_EVENTS_ENABLE_TLS=true
  • STORAGE_USERS_EVENTS_ENABLE_TLS=true

@micbar micbar requested a review from rhafer October 21, 2022 10:43
@micbar micbar requested a review from mmattel October 21, 2022 10:50
@micbar micbar marked this pull request as ready for review October 21, 2022 10:51
@micbar micbar self-requested a review October 21, 2022 10:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
8.5% 8.5% Duplication

@micbar micbar merged commit 5146d16 into master Oct 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the nats-tls branch October 21, 2022 11:37
This was referenced Oct 21, 2022
Closed
Closed
ownclouders pushed a commit that referenced this pull request Oct 21, 2022
@micbar
commit 5146d16
42bb0be 
Merge: ff8b16f ec764ea
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Oct 21 13:37:18 2022 +0200

    Merge pull request #4867 from owncloud/nats-tls

    add config option to enable or disable TLS for nats
ownclouders pushed a commit that referenced this pull request Oct 21, 2022
@micbar
commit 5146d16
cc5f3f2 
Merge: ff8b16f ec764ea
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Oct 21 13:37:18 2022 +0200

    Merge pull request #4867 from owncloud/nats-tls

    add config option to enable or disable TLS for nats
@mmattel mmattel mentioned this pull request Oct 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@mmattel mmattel Awaiting requested review from mmattel

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@C0rby @rhafer @mmattel @micbar