Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] Fix notification readme and translation comments #6090

Merged
merged 4 commits into from Apr 19, 2023

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Apr 19, 2023

References: #6025 (Make Emails translatable via transifex)

This PR updates the:

  • README.md to clarify how things get assembled
  • comment strings so one can see with which placeholders a string is resolved

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 6c6c15d into master Apr 19, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_notification_readme branch April 19, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants