Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idp: Use the UUID attribute for computing the "sub" claim #6326

Merged
merged 2 commits into from May 16, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented May 16, 2023

This avoids that recreating the user with the same name will create the
same "sub" claim. Even though it gets a new UUID

Fixes: #904

@update-docs
Copy link

update-docs bot commented May 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer rhafer requested a review from micbar May 16, 2023 11:27
@micbar
Copy link
Contributor

micbar commented May 16, 2023

@rhafer the real change seems to be very small.

which 3rd party libs did you bump?

@micbar
Copy link
Contributor

micbar commented May 16, 2023

Needs a changelog, otherwise it seems to be fine.

@rhafer
Copy link
Contributor Author

rhafer commented May 16, 2023

which 3rd party libs did you bump?

@micbar only libregraph/lico, but that itself bumped quite a few dependencies since with the 0.60.0 release. If you prefer I can apply the fix to lico 0.59.4, that wouldn't cause as many dependency bumps.

@rhafer
Copy link
Contributor Author

rhafer commented May 16, 2023

libregraph/lico#95 got merged meanwhile. I'll remove my fork and bump to lico latest master.

@rhafer rhafer force-pushed the issue/904 branch 3 times, most recently from ab6be5e to 9736599 Compare May 16, 2023 12:56
This avoids that recreating the user with the same name will create the
same "sub" claim. Even though it gets a new UUID

Fixes: owncloud#904
This is need for getting this fix: libregraph/lico#95
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rhafer rhafer merged commit 6c6ec2d into owncloud:master May 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Browser session is valid for newly created user of same name
2 participants