Fix preview or viewing of shared animated GIFs #6386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled... |
2403905
force-pushed
the
issue-5418
branch
2 times, most recently
from
22fc8a3
to
fb786ec
Compare
|
Why do we need changes on the protobuf? |
kobergj
requested changes
May 25, 2023
This reverts commit dba4251.
The reason why I did it is to set the default value jpg based on the logic that was used. So, I just checked again. It is not necessary. I rolled that commit back. |
micbar
requested changes
May 25, 2023
2403905
force-pushed
the
issue-5418
branch
2 times, most recently
from
793f0c6
to
d62fc09
Compare
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
May 26, 2023
ownclouders
pushed a commit
that referenced
this pull request
May 26, 2023
* Fix preview or viewing of shared animated GIFs --------- Co-authored-by: Roman Perekhod <rperekhod@owncloud.com>
86 tasks
fschade
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Fix preview or viewing of shared animated GIFs --------- Co-authored-by: Roman Perekhod <rperekhod@owncloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix preview or viewing of shared animated GIFs
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: