allow skipping userinfo call #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
allow-skip-userinfo
branch
2 times, most recently
from
6e8a5fd
to
3020ca2
Compare
mmattel
reviewed
Aug 23, 2023
rhafer
approved these changes
Aug 23, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Martin <github@diemattels.at>
butonic
force-pushed
the
allow-skip-userinfo
branch
from
dccc766
to
91a77d1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Aug 23, 2023
allow skipping userinfo call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AD FS only ever returns the
subclaim at the/userinfoendpoint. This PR makes reading the userid claim directly from the access token the default by settingPROXY_OIDC_SKIP_USER_INFO=trueandPROXY_USER_OIDC_CLAIM="lg\\.i.un"(fromPROXY_USER_OIDC_CLAIM=preferred_username).This will is a breaking change as it will no longer defailt to miking a call to the userinfo endpoint AND requires the username to be read from the access token.