Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SSE Notifications #7325

Merged
merged 3 commits into from Sep 22, 2023
Merged

Improve SSE Notifications #7325

merged 3 commits into from Sep 22, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Sep 21, 2023

Improves SSE notifications format to fulfill the needs of the web client

@kobergj
improve sse for userlog
6e8f168 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
improve sse sending in clientlog service
b59fec9 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj marked this pull request as ready for review September 22, 2023 07:52
AlexAndBear
AlexAndBear approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not to happy about the typ var name but that's on you

@kobergj
make picky variable namers happy
586bae4 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit 0535c62 into owncloud:master Sep 22, 2023
3 checks passed
@kobergj kobergj deleted the SEEImprovements branch September 22, 2023 10:45
ownclouders pushed a commit that referenced this pull request Sep 22, 2023
@kobergj
Merge pull request #7325 from kobergj/SEEImprovements
e270a9d 
Improve SSE Notifications
@JammingBen JammingBen mentioned this pull request Sep 29, 2023
Closed
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kobergj @AlexAndBear