Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add last modified filter chip #7455

Merged
merged 2 commits into from Oct 19, 2023
Merged

add last modified filter chip #7455

merged 2 commits into from Oct 19, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Oct 10, 2023 •
edited

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@mmattel mmattel mentioned this pull request Oct 11, 2023
Open
@2403905 2403905 force-pushed the issue-7431 branch 2 times, most recently from 3711ae1 to a39e6bd Compare October 13, 2023 08:11
@2403905 2403905 marked this pull request as ready for review October 17, 2023 07:58
@2403905 2403905 requested a review from fschade October 17, 2023 07:58
fschade
fschade approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little meta thing, expect that, LGTM 🚀

@2403905 2403905 force-pushed the issue-7431 branch 3 times, most recently from 232e83b to 2051f8a Compare October 19, 2023 08:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@2403905 2403905 merged commit acfae80 into owncloud:master Oct 19, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Oct 19, 2023
@2403905
add last modified filter chip (#7455)
c518cf2 
* add last modified filter chip

* Update add-last-modified-filter-chip.md

---------

Co-authored-by: Roman Perekhod <rperekhod@owncloud.com>
@fschade fschade mentioned this pull request Oct 20, 2023
Merged
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@2403905 @fschade