[full-ci] Set mountpoints when auto accepting shares #7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
SetMountpointOnAutoAccept
branch
2 times, most recently
from
1ab7846
to
833ff6c
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
SetMountpointOnAutoAccept
branch
from
e1b3946
to
ed9525b
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
SetMountpointOnAutoAccept
branch
from
ed9525b
to
b33dbba
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rhafer
approved these changes
Oct 12, 2023
|
|
||
| On shares auto accept set a mountpoint with same logic as ocs handler | ||
|
|
||
| https://github.com/owncloud/ocis/pull/7460 |
There was a problem hiding this comment.
Nit: Would be cool to have the fixed issues linked here and in the commit message as well .
There was a problem hiding this comment.
What do you mean by "in the commit message as well"? How should the commit message look like?
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the mountpoint when auto accepting shares
Fixes #7441
Fixes #7440
also fixes a race condition in the ocis wrapper