Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auth service env variable #7523

Merged
merged 1 commit into from Oct 18, 2023
Merged

fix auth service env variable #7523

merged 1 commit into from Oct 18, 2023

Conversation

wkloucek
Copy link
Contributor

Description

fix the auth service env variable to the service specific name. Before it was configurable via AUTH_MACHINE_JWT_SECRET and now is configurable via AUTH_SERVICE_JWT_SECRET.

Related Issue

Motivation and Context

Consistent env variable naming

How Has This Been Tested?

  • not tested other than CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy pasta. Thanks for finding!

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit c300b89 into master Oct 18, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the auth-service-jwt branch October 18, 2023 16:16
ownclouders pushed a commit that referenced this pull request Oct 18, 2023
@@ -0,0 +1,5 @@
Bugfix: Fix the auth service env variable

We the auth service env variable to the service specific name. Before it was configurable via `AUTH_MACHINE_JWT_SECRET` and now is configurable via `AUTH_SERVICE_JWT_SECRET`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We the auth service env variable

@wkloucek you and the auth-service, nice 🤣
Maybe you want to fix that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants