enhancement: improve content extraction stop word cleaning #7553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
approved these changes
Oct 20, 2023
mmattel
reviewed
Oct 20, 2023
changelog/unreleased/enhancement-search-content-extraction-cleanup.md
Outdated
Show resolved
Hide resolved
mmattel
reviewed
Oct 20, 2023
changelog/unreleased/enhancement-search-content-extraction-cleanup.md
Outdated
Show resolved
Hide resolved
mmattel
reviewed
Oct 20, 2023
fschade
force-pushed
the
search-remove-stop-words
branch
from
660d9f6
to
8134151
Compare
Co-authored-by: Martin <github@diemattels.at>
fschade
force-pushed
the
search-remove-stop-words
branch
from
4c1c32e
to
55f39d3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Oct 23, 2023
* enhancement: improve content extraction stop word cleaning * fix: cleanup documentation Co-authored-by: Martin <github@diemattels.at> * fix: failing tika stop word unit tests --------- Co-authored-by: Martin <github@diemattels.at>
nabim777
pushed a commit
that referenced
this pull request
Oct 26, 2023
* enhancement: improve content extraction stop word cleaning * fix: cleanup documentation Co-authored-by: Martin <github@diemattels.at> * fix: failing tika stop word unit tests --------- Co-authored-by: Martin <github@diemattels.at>
mmattel
added a commit
that referenced
this pull request
Nov 3, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
fschade
pushed a commit
that referenced
this pull request
Nov 3, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
ownclouders
pushed a commit
that referenced
this pull request
Nov 3, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
ownclouders
pushed a commit
that referenced
this pull request
Nov 4, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
ownclouders
pushed a commit
that referenced
this pull request
Nov 5, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
ownclouders
pushed a commit
that referenced
this pull request
Nov 6, 2023
References: #7553 (enhancement: improve content extraction stop word cleaning) Making the term `stop word` and the use of the envvar more clear.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far it has not been possible to determine whether
the content for the search should be cleaned of stop words or not.
This can now be set with the newly introduced settings option
SEARCH_EXTRACTOR_TIKA_CLEAN_STOP_WORDS=falsewhich is enabled by default.
In addition, the stop word cleanup is no longer as aggressive and now ignores numbers, urls,
basically everything except the defined stop words.
Related Issue
Motivation and Context
..., no bugs, ... yummy
How Has This Been Tested?
Types of changes
Checklist: