[full-ci] fix public link update

[2403905]

Description

We fixed enforce password when normal users can update the public link to delete its password if permission is not sent in data

Related Issue

• Fixes Normal users can update the public link to delete its password if permission is not sent in data #7821

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[SwikritiT]

Hi @2403905 I tried your changes locally the failing test needs a little update

the test in acceptance/features/coreApiSharePublicLink3/updatePublicLinkShare.feature:104

  Scenario Outline: creating a new public link share with password and removing (updating) it to make the resources accessible without password using public API
    Given using OCS API version "<ocs_api_version>"
    And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt"
    And user "Alice" has created a public link share with settings
      | path     | randomfile.txt |
      | password | %public%       |
    When user "Alice" updates the last public link share using the sharing API with
      #removing password is basically making password empty
      | password | %remove% |
    Then the OCS status code should be "<ocs_status_code>"
    And the HTTP status code should be "200"
    And the public should be able to download the last publicly shared file using the old public WebDAV API without a password and the content should be "Random data"
    And the public should be able to download the last publicly shared file using the new public WebDAV API without a password and the content should be "Random data"
    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
      | 2               | 200             |

Previously the user could remove the password of a link but now they cannot so I think this update is okay based on what is expected of the server. One little change though is that the http status code is different now depending on the ocs version for /ocs/v2.php/apps/files_sharing/api/v1/shares the http status is 403 while it's 200 for /ocs/v1.php/apps/files_sharing/api/v1/shares. Now the scenario is something like this

  Scenario Outline: creating a new public link share with password and removing (updating) it
    Given using OCS API version "<ocs_api_version>"
    And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt"
    And user "Alice" has created a public link share with settings
      | path     | randomfile.txt |
      | password | %public%       |
    When user "Alice" updates the last public link share using the sharing API with
      #removing password is basically making password empty
      | password | %remove% |
    Then the OCS status code should be "104"
    And the HTTP status code should be "<http_status_code>"
    Examples:
      | ocs_api_version | http_status_code |
      | 1               | 200              |
      | 2               | 403              |

I think we can remove this scenario as this case is covered here in this scenario below

ocis/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature

Line 136 in c8dc52c

Scenario Outline: normal user tries to remove password of a public link share (change/create permission)

, I'll make a update PR to include both ocs versions in the test.

Furthermore , can you please rebase this PR with the master to get the changes from this PR #7828 ? You should get the unexpected pass if the changes work as expected.

[SwikritiT]

The changes fixes the issue #7821 however tests need a little adjustment in the error message and status code here

ocis/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature

Lines 163 to 164 in c8dc52c

	And the OCS status code should be "400"
	And the OCS status message should be "missing required password"

These two lines need to be updated to

    And the OCS status code should be "104"
    And the OCS status message should be "user is not allowed to delete the password from the public link"

[SwikritiT]

API tests should pass now after the removal of

ocis/tests/acceptance/expected-failures-API-on-OCIS-storage.md

Lines 518 to 520 in 62afc6e

	#### [Normal users can update the public link to delete its password if permission is not sent in data](https://github.com/owncloud/ocis/issues/7821)
	- [coreApiSharePublicLink1/changingPublicLinkShare.feature:154](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature#L154)

[saw-jan]

This can be removed

Suggested change

	And the OCS status code should be "104"
	And the OCS status message should be "user is not allowed to delete the password from the public link"

[SwikritiT]

These as well

ocis/tests/acceptance/expected-failures-API-on-OCIS-storage.md

Line 518 in 7acb111

#### [Normal users can update the public link to delete its password if permission is not sent in data](https://github.com/owncloud/ocis/issues/7821)

[saw-jan]

^
@2403905 tests are passing. Please, remove passing tests from the expected failure list.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information