Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] graph sharing: Fixes for UpdateShare #7963

Merged
merged 3 commits into from Dec 15, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Dec 13, 2023

This fixes two smaller issue in the UpdateShare handler:

  • We were using some deprecated attribute in the CS3 UpdateShare request
  • a return statement was missing under some error conditions we return an invalid response

This needs: cs3org/reva#4405

Copy link

update-docs bot commented Dec 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer rhafer force-pushed the update-share-permission-check branch 4 times, most recently from a5e1cab to f980e09 Compare December 14, 2023 09:55
@rhafer rhafer closed this Dec 14, 2023
@rhafer rhafer reopened this Dec 14, 2023
@rhafer rhafer force-pushed the update-share-permission-check branch from f980e09 to d095f3f Compare December 14, 2023 11:01
@rhafer rhafer changed the title [full-ci][do-not-merge] testing reva pr [full-ci] graph sharing: Fixes for UpdateShare Dec 14, 2023
rhafer and others added 3 commits December 15, 2023 14:48
The sharereference attribute in the CS3 UpdateShareRequest is deprecated.
Set the shareid via the Share.ID attribute.
@micbar micbar force-pushed the update-share-permission-check branch from d095f3f to 92966ff Compare December 15, 2023 13:52
@micbar micbar marked this pull request as ready for review December 15, 2023 13:53
Copy link

sonarcloud bot commented Dec 15, 2023

@micbar micbar merged commit 10486b5 into owncloud:master Dec 15, 2023
3 checks passed
ownclouders pushed a commit that referenced this pull request Dec 15, 2023
[full-ci] graph sharing: Fixes for UpdateShare
@micbar micbar mentioned this pull request Dec 20, 2023
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants