[full-ci] Service Account Roles #8051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
ServiceAccountRoles
branch
from
1b2c61d
to
20f77d4
Compare
rhafer
previously requested changes
Dec 21, 2023
| @@ -46,6 +46,7 @@ func NewService(cfg *config.Config, logger log.Logger) settings.ServiceHandler { | |||
| case "metadata": | |||
| service.manager = metastore.New(cfg) | |||
| case "filesystem": | |||
| fmt.Println("WARNING: filesystem store is deprecated and will be removed in the future. Please use metadata store instead.") | |||
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
ServiceAccountRoles
branch
from
e397b58
to
a607c63
Compare
|
2403905
approved these changes
Dec 22, 2023
ownclouders
pushed a commit
that referenced
this pull request
Dec 22, 2023
[full-ci] Service Account Roles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hidden role for service accounts. This role will give the service account all permissions it needs but will not appear in list roles calls. Also it doesn't need the default role assignments to work.
Fixes: https://github.com/owncloud/enterprise/issues/6286
Also deprecates
filesystemsettings storeNOTE: This is a breaking change. It removes the (unreleased)
SETTINGS_SERVICE_ACCOUNT_ID_ADMINenvironment variable without deprecation