[tests-only][full-ci] added test to send share invitation to non-existing group #8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
PrajwolAmatya
requested review from
grgprarup,
SwikritiT,
saw-jan,
amrita-shrestha,
S-Panta and
nirajacharya2
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
770b5b6
to
898d5ad
Compare
amrita-shrestha
previously requested changes
Jan 11, 2024
Comment on lines
974
to
1149
| | Viewer | file | /textfile1.txt | | ||
| | File Editor | file | /textfile1.txt | | ||
| | Co Owner | file | /textfile1.txt | | ||
| | Manager | file | /textfile1.txt | | ||
| | Viewer | folder | FolderToShare | | ||
| | Editor | folder | FolderToShare | | ||
| | Co Owner | folder | FolderToShare | | ||
| | Uploader | folder | FolderToShare | | ||
| | Manager | folder | FolderToShare | |
There was a problem hiding this comment.
all role should not be allowed to file resource see issue #8131
There was a problem hiding this comment.
Currently every role can be assigned on the file, and this same example table is being used in every other Scenario. What should we do about it? Should we do it as it is or should we wait for some fixes?
cc @amrita-shrestha @saw-jan
There was a problem hiding this comment.
I really don't know what roles should be permitted while sharing a file/folder. If it is known then we can make another PR for removing not permitted roles and add some coverage for trying to share with not permitted roles. Then block that PR until the fix arrives
But I don't think we need to block this one.
saw-jan
reviewed
Jan 12, 2024
tests/acceptance/features/apiSharingNg/shareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
898d5ad
to
4416991
Compare
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
4416991
to
292b144
Compare
SagarGi
reviewed
Jan 18, 2024
tests/acceptance/features/apiSharingNg/shareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
292b144
to
52feb4e
Compare
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
52feb4e
to
c4b9850
Compare
saw-jan
reviewed
Jan 23, 2024
tests/acceptance/features/apiSharingNg/shareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
c4b9850
to
30e226d
Compare
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
2 times, most recently
from
f600883
to
379f884
Compare
saw-jan
reviewed
Jan 24, 2024
tests/acceptance/features/apiSharingNg/shareInvitations.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
send-share-invitation-unknown-group
branch
from
379f884
to
36cc281
Compare
|
delete-merged-branch
bot
deleted the
send-share-invitation-unknown-group
branch
saw-jan
changed the title
ownclouders
pushed a commit
that referenced
this pull request
Jan 24, 2024
PrajwolAmatya
added a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test scenario to send share invitation to unknown group.
Expected: sharing should fail with status code
400Added Scenario:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: