Cleanup driveitems.go
#8228
Merged
Cleanup driveitems.go
#8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2403905
approved these changes
Jan 17, 2024
rhafer
reviewed
Jan 17, 2024
| @@ -741,7 +740,7 @@ func (g Graph) getCS3UserShareByID(ctx context.Context, permissionID string) (*c | |||
| return getShareResp.GetShare(), nil | |||
| } | |||
|
|
|||
| func (g Graph) updateUserShare(ctx context.Context, permissionID string, oldPermission, newPermission *libregraph.Permission) (*libregraph.Permission, error) { | |||
| func (g Graph) updateUserShare(ctx context.Context, permissionID string, _, newPermission *libregraph.Permission) (*libregraph.Permission, error) { | |||
There was a problem hiding this comment.
Please remove the oldPermissions parameter completely from the method signature. AFAICS there is only one caller and this is some leftover that was overlooked during review.
rhafer
requested changes
Jan 17, 2024
Signed-off-by: jkoberg <jkoberg@owncloud.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main intend is to use proto getters to avoid panics.
Fixes #7899
This also fixes some other issues that made my IDE sad and angry.