Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump reva #8260

Closed
wants to merge 1 commit into from
Closed

Conversation

dragonchaser
Copy link
Member

@dragonchaser dragonchaser commented Jan 22, 2024

This PR bumps reva (removing locks from grants thus allowing sharing of files open in wopi applications)
refs #6368

@dragonchaser dragonchaser changed the base branch from bump-reva to master January 22, 2024 14:35
@dragonchaser dragonchaser force-pushed the bump-reva branch 2 times, most recently from 3b44576 to 4f511cf Compare January 22, 2024 14:46
Signed-off-by: Christian Richter <crichter@owncloud.com>
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dragonchaser dragonchaser marked this pull request as ready for review January 22, 2024 15:57
@owncloud owncloud deleted a comment from update-docs bot Jan 22, 2024
@micbar
Copy link
Contributor

micbar commented Jan 22, 2024

@ScharfViktor @saw-jan The test expectations about sharing NG are wrong.

@saw-jan
Copy link
Member

saw-jan commented Jan 22, 2024

@ScharfViktor @saw-jan The test expectations about sharing NG are wrong.

The fix cs3org/reva#4462 came along with the bump. We need to change the test expectation

@ScharfViktor
Copy link
Contributor

yes, we need change tests after fixing cs3org/reva#4462
I tried to fix it in this branch dragonchaser:bump-reva but I haven't access

one question:
@rhafer added checking for sharing file provider.ResourceType_RESOURCE_TYPE_FILE

what about folders ? Can users share folders using space roles?

Screenshot 2024-01-22 at 20 43 56

@micbar
Copy link
Contributor

micbar commented Jan 22, 2024

@ScharfViktor

I think we need to change the testsuite fundamentally here. The point of Sharing NG is, that the clients should not have any knowledge about the sharing roles, except that they need to ask for the "what can i do on that resource" call every time. (https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions)

@micbar
Copy link
Contributor

micbar commented Jan 22, 2024

@dragonchaser updated reva again.

Will fix test expectations now.

@micbar
Copy link
Contributor

micbar commented Jan 22, 2024

closing here, further work in #8264

@dragonchaser @2403905 Please also add a changelog to each reva bump.

@micbar micbar closed this Jan 22, 2024
auto-merge was automatically disabled January 22, 2024 20:42

Pull request was closed

@ScharfViktor
Copy link
Contributor

they need to ask for the "what can i do on that resource" call every time. (https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions)

then ListPermissions apiMethod is not working correctly because user gets all permissions.roles and permissions.actions for file, folder and space

@micbar
Copy link
Contributor

micbar commented Jan 22, 2024

then ListPermissions apiMethod is not working correctly because user gets all permissions.roles and permissions.actions for file, folder and space

Correct. Comes with #8247

@dragonchaser dragonchaser deleted the bump-reva branch February 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants