-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Bump reva #8260
[full-ci] Bump reva #8260
Conversation
3b44576
to
4f511cf
Compare
4f511cf
to
0c6cc9c
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@ScharfViktor @saw-jan The test expectations about sharing NG are wrong. |
The fix cs3org/reva#4462 came along with the bump. We need to change the test expectation |
yes, we need change tests after fixing cs3org/reva#4462 one question: what about folders ? Can users share folders using |
I think we need to change the testsuite fundamentally here. The point of Sharing NG is, that the clients should not have any knowledge about the sharing roles, except that they need to ask for the "what can i do on that resource" call every time. (https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions) |
@dragonchaser updated reva again. Will fix test expectations now. |
closing here, further work in #8264 @dragonchaser @2403905 Please also add a changelog to each reva bump. |
Pull request was closed
then |
Correct. Comes with #8247 |
This PR bumps reva (removing locks from grants thus allowing sharing of files open in wopi applications)
refs #6368