Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] adding test for updating role of a share #8329

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[tests-only] adding test for updating role of a share #8329

merged 1 commit into from
Feb 8, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jan 31, 2024 •
edited

Description

Scenarios added :

Scenario Outline: user updates role of a share

and moving permission related tests to updatePermission.feature from shareByMe.feature`

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jan 31, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 31, 2024
Closed
13 tasks
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-role branch 4 times, most recently from 80d274d to bc5f8b0 Compare February 1, 2024 10:07
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for updating role of a share [tests-only] adding test for updating role of a share Feb 1, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-role branch 5 times, most recently from 7c8b4d4 to 0733b2b Compare February 5, 2024 07:06
@nirajacharya2 nirajacharya2 marked this pull request as ready for review February 5, 2024 07:06
amrita-shrestha
amrita-shrestha reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

tests/acceptance/features/apiSharingNg/sharedByMe.feature Outdated Show resolved Hide resolved
@grgprarup
Copy link
Contributor

The tests added in this PR and some scenarios in the file sharedByMe.feature are related to updating the share, so it will be better to put those in a separate file (updateShareInvitations).

@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-role branch 2 times, most recently from 3f55258 to 7102487 Compare February 6, 2024 09:59
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-role branch 2 times, most recently from 2c944c3 to 42cc8a2 Compare February 7, 2024 04:26
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-role branch 5 times, most recently from 4ef012c to 499450f Compare February 7, 2024 06:56
grgprarup
grgprarup reviewed Feb 7, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/updateShareInvitations.feature
@@ -0,0 +1,160 @@
Feature: Update permission of a share
As a user
I want to update resources shared with me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the share updated by a sharer?

grgprarup
grgprarup approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some typos. LGTM 👍

saw-jan
saw-jan requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not squish with other commits

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit d87f5b0 into master Feb 8, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-share-by-me-update-role branch February 8, 2024 09:07
ownclouders pushed a commit that referenced this pull request Feb 8, 2024
@nirajacharya2
adding test for updating role of a share (#8329)
3337b80
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nabim777 nabim777 Awaiting requested review from nabim777

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nirajacharya2 @grgprarup @saw-jan @amrita-shrestha @S-Panta