Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bump reva]fix an error when move using destination id #8396

Merged
merged 1 commit into from Feb 8, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Feb 7, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: local
  • admin created the file.txt file and dist folder in a personal root
  • The expected response is HTTP 204 for each move API call
curl 'https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000/file.txt' \
  -X 'MOVE' \
  -H 'Destination: https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!6487a41a-872e-4fb4-a6ea-d6c53920392e' \
-uadmin:admin -ik


curl 'https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!4974bc0a-af79-4a6b-a998-08610df230ce' \
  -X 'MOVE' \
  -H 'Destination: https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000/dest' \
-uadmin:admin -ik


curl 'https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!6487a41a-872e-4fb4-a6ea-d6c53920392e' \
  -X 'MOVE' \
  -H 'Destination: https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!4974bc0a-af79-4a6b-a998-08610df230ce' \
-uadmin:admin -ik


curl 'https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!4974bc0a-af79-4a6b-a998-08610df230ce' \
  -X 'MOVE' \
  -H 'Destination: https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!6487a41a-872e-4fb4-a6ea-d6c53920392e' \
-uadmin:admin -ik

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@2403905 2403905 marked this pull request as ready for review February 8, 2024 13:28
@2403905 2403905 changed the title fix an error when move using destination id [bump reva]fix an error when move using destination id Feb 8, 2024
@2403905 2403905 merged commit bd22de3 into owncloud:master Feb 8, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Feb 8, 2024
[bump reva]fix an error when move using destination id
@micbar micbar mentioned this pull request Feb 26, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moving a file and providing the fileID of the destination destroys data
2 participants