make store service configurable

[butonic]

The store service was born out of a misunderstanding ... we need to clean that up. This PR changes the default signing key store to nats, but allows configuring and using the old store service to running existing installations without changes to the deployment (if updating the configuratin).

The change does not need a migration as signing keys are just regenerated on the fly.

I don't know if the web ui will re download the signing key if it expired. I don't think it has a way of detecting that as the browser will handle the download. Maybe they should just forget the signing key ... every 5min? so it is periodically refetched?

I can see the ocis web ui being left open for a long time, so I set the new signing key TTL default to 12h. In the past it never expired, which IMO is a pad practice.

cc @mmattel @wkloucek @kobergj @kulmann

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

Removing the store service is great, as it reduces the list of services not having a description about their purpose 🤣 @kobergj

[mmattel]

Ok, means:

• We need to add entries in the changed envvars tables (added, removed).
• Reverse the entries made by New Service Checklist like in the makefile in ocis repo root etc.
• Add the caching info to the ocs readme in the same way we have like in the proxy readme.
• Clarification needed (same for PROXY_):
  OCS_PRESIGNEDURL_SIGNING_KEYS_STORE_DATABASE and
  OCS_PRESIGNEDURL_SIGNING_KEYS_STORE_TABLE
  Reason, default values --> improve description text

[DeepDiver1975]

• How is migration handled in this scenario?

[butonic]

Migration is not needed as the keys are ephemeral and can just be regenerated.

[butonic]

I forgot to not start the store service by default. will change the default services.

[ScharfViktor]

fail while building ocis binary make -C ocis clean generate build

go build -v -tags 'disable_crypt' -ldflags '-X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=warn -s -w -X "github.com/owncloud/ocis/v2/ocis-pkg/version.String=71dd19bf4b" -X "github.com/owncloud/ocis/v2/ocis-pkg/version.Tag=" -X "github.com/owncloud/ocis/v2/ocis-pkg/version.Date=20240223"' -o bin/ocis ./cmd/ocis
../services/ocs/pkg/server/http/server.go:14:2: cannot find module providing package github.com/owncloud/ocis/v2/services/store/pkg/store: import lookup disabled by -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [bin/ocis] Error 1

[kobergj]

LGTM 👍

[sonarcloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
4.6% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarCloud

addressed