fixed sharing invite on a virtual drive #8610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Hm, in general this is ok, but IMO this does not really fix the reported issue (#8495).
I think there is already problem in the usershareprovider. It should forbid all share creation requests against any space root.
The fact that we got an error from the sharestorageprovider seems to indicate that we already succeeded creating the share in the usershareprovider, that shoud not have happen when the share is targeting a space root.
2403905
force-pushed
the
issue-8495
branch
2 times, most recently
from
afa504a
to
bfb04f8
Compare
2403905
changed the title
|
@rhafer Already reworked. Here is a reva changes cs3org/reva#4568 |
|
rhafer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed sharing invite on a virtual drive
Related fix cs3org/reva#4568
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: