Enhancement: Ability to Change Share Item Visibility in Graph API

[fschade]

Description

This PR introduces an enhancement and introduces the PUT /graph/v1beta1/drives/{driveID}/items/{itemID} Graph API endpoint, which now allows updating individual Drive Items.

At the moment, the primary changeable property is the share visibility. This enhancement is required for the UI, allowing specific shares to be hidden or unhidden as needed, thereby improving the user experience.

While currently, only the share visibility is considered changeable, this update lays the groundwork for adding more properties to this endpoint in the future.

Related Issue

• Fixes [Sharing NG] Make @UI.hidden property editable through API #8654

Motivation and Context

This change provides more control over the visibility of shared items, improving the user experience and offering a new level of flexibility and control to the users.

How Has This Been Tested?

• unit tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

ToDos:

• Add Unit tests
• Add Acceptance tests
• Document endpoint in https://github.com/owncloud/libre-graph-api

[fschade]

i wasn't able to finalize the PR, i can continue working on it after my vacation which would be the week after the next.
Most is implemented already, if someone could continue on in in the meantime im fine, thanks.

[rhafer]

This PR introduces an enhancement and introduces the PUT /graph/v1beta1/drives/{driveID}/items/{itemID}

Why a PUT? I think we want PATCH here. And AFAIU your PR does implement PATCH semantics?

[fschade]

This PR introduces an enhancement and introduces the PUT /graph/v1beta1/drives/{driveID}/items/{itemID}

Why a PUT? I think we want PATCH here. And AFAIU your PR does implement PATCH semantics?

you’re right, I missed that 🤗

[rhafer]

I think the hide/unhide thing needs to update all received shares for the same resource. (Similar to how mount/unmount update the synchronize flag on all shares)

Also raised some questions, where I'd like to understand some of the reasons for the changes.

In general I think it would be easier to review this PR if the changes that just refactor stuff were done in separate commits. It's ok. After all this is not too big. But you might want to consider it for the future.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.6% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud