This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Redesign notifications #2210
Merged
Redesign notifications #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
redesign-notifications
branch
from
663c82e
to
f514d1c
Compare
|
Update - lowered the icon size and made it align with the heading & adding padding/margin to the text to align nicer with the heading
|
2 tasks
pascalwengerter
commented
Jun 21, 2022
| &-warning { | ||
| color: var(--oc-color-swatch-warning-default) !important; | ||
| border-color: var(--oc-color-swatch-warning-default); | ||
| @keyframes fadeIn { |
There was a problem hiding this comment.
I'll extract this into an animation class/SCSS file for reusability and also make it respect the browser's prefers-reduced-motion setting
pascalwengerter
force-pushed
the
redesign-notifications
branch
from
d34a84a
to
3e06fb0
Compare
Stylelint animations
pascalwengerter
force-pushed
the
redesign-notifications
branch
from
3e06fb0
to
58a3093
Compare
lookacat
reviewed
Jun 21, 2022
lookacat
approved these changes
Jun 21, 2022
pascalwengerter
force-pushed
the
redesign-notifications
branch
from
58a3093
to
927760a
Compare
Move OcNotificationMessage to atoms Fix notifications unit test Fix OcNotification position validator
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Groundwork for owncloud/web#7082