Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Change remove click event oc icon #2216

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Conversation

pascalwengerter
Copy link
Contributor

Description

Extracted from #2165

@pascalwengerter pascalwengerter marked this pull request as ready for review June 22, 2022 11:09
@@ -0,0 +1,6 @@
Change: Remove click event on OcIcon
Copy link
Member

@kulmann kulmann Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO not a change, but an enhancement, maybe even just a bugfix. Before this PR the click handler on ocIcon would be used like this:

<oc-icon @click="someCallback" />

Since the click handler was living on the root component of the template, writing the code above would still emit a click event like before, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still add an event handler like the someCallback example you provided. In theory it's a change because someone somewhere out there might have something listening on an OcIcon emitting a click event, but can re-scope the changelog item if necessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the only way to listen to that click event is by adding a click handler like in the example above. Or could also be that I'm just missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am? 🤔 let me change it to a bugfix changelog then

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit a39b8b2 into master Jun 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the change-remove-clickEvent-oc-icon branch June 22, 2022 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants