Make ui small again

[lookacat]

Description

See owncloud/web#7333

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation added/updated

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[tbsbdr]

Primary / Secondary Button have different height / (outline border?)

Custom font is not rendered (cause: not bundeled?)
I'd favor to use a more characteristic font that fits to the round/organic ui like the font "Nunito"

[lookacat]

@tbsbdr i have no idea what both issues is causing since i didn't change anything about that :/ Outline border seems to have no effect even on demo.owncloud.com

[tbsbdr]

Regarding the custom font: We have always had the problem with custom fonts - its not embedded in web afaik (and also not loaded via a CDN which is good)

[kulmann]

More things broken with the primary button style, see button group screenshot (below) from the OcButton docs page.

[tbsbdr]

@lookacat if we ship a Open Font Licence (OFL) -licenced  font, we must at least link (https://scripts.sil.org/OFL) to the OFL Licence

Source: https://scripts.sil.org/cms/scripts/page.php?item_id=OFL-FAQ_web#e71fabc0

Question: 1.10 Does the full OFL license text always need to accompany the font?

Answer: The only situation in which an OFL font can be distributed without the text of the OFL (either in a separate file or in font metadata), is when a font is embedded in a document or bundled within a program. In the case of metadata included within a font, it is legally sufficient to include only a link to the text of the OFL on https://scripts.sil.org/OFL, but we strongly recommend against this. Most modern font formats include metadata fields that will accept the full OFL text, and full inclusion increases the likelihood that users will understand and properly apply the license.

[tbsbdr]

@lookacat just to make sure that you are aware of this - i think we talked about it: Nunito is currently not shown as we don't bundle any custom web fonts - so if you don't have any of the fonts like roboto or nunito already installed on your local system, custom fonts don't show up in ownCloud Web.

how to reproduce

• disable the respective in font book on mac via: 
   

• reload local instance
• Nunito is not rendered

Expected behavior

the respective ownCloud Web font (Nunito) should be included in the App (no ad-hoc download from any public CDN to protect users privacy)

[tbsbdr]

almost there ;-)

✅ Font is now rendered, even if its not installed on the local machine

❌ Font is loaded from Google CDN -> GDPR violation, not privacy compliant

Font should be bundeled so that the client does not need to contact a Google CDN

[kulmann]

You added the font ttf file but you're not embedding it anywhere. Either you use the WebFontLoader with custom option (see docs) or you embed the ttf file and get rid of the WebFontLoader entirely. With this PR freshly pulled and built I see Helvetica on my machine.

[lookacat]

embedded it via web via css, but ill try the custom option

[kulmann]

embedded it via web via css, but ill try the custom option

Please embed from within ODS.

[kulmann]

FYI, I wanted to use family here, but that didn't show up at all in the compiled tokens. Since that's only the docs I don't care too much and chose a different key...

[kulmann]

Converted back to draft. Font embedding works now, but the oc-text-* classes feel broken. And still finetuning the font sizes...

[kulmann]

good now 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication